[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] cleanup fails on missing .svn/tmp

From: Henner Zeller <h.zeller_at_acm.org>
Date: 2007-02-07 09:15:35 CET

Hi,
> Well, but the fact that the tmp area is missing doesn't tell us
> whether it was between a failed operation and a rerun of logs and
> whether it was empty or not, or am I misunderstanding what the patch
> is supposed to fix?

This patch changes a piece of code that would dump .svn/tmp
completely, unconditionally and without checking if there is something
in these directories. It will only be called after logs have been run
(successfully).

The function I am changing is svn_wc__adm_cleanup_tmp_area() and it is
only called in svn_wc_cleanup2() after everything is done. The comment
before calling the function sais "...The logs have been run, so
anything left here has no hope of being useful".

cheers,
 -henner

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Feb 7 09:15:47 2007

This is an archived mail posted to the Subversion Dev mailing list.