Re: [PATCH]remove unused parameter

Looks good Kamesh, +1. Please commit.

- Dan

On Mon, 05 Feb 2007, Kamesh Jayachandran wrote:

> Hi All,
>
> Find the attached patch and log.
>
> With regards
> Kamesh Jayachandran

> [[[
> Remove unused parameter 'pool' from get_fs_path().
>
> * subversion/svnserve/serve.c
> (get_fs_path): Remove the unused param 'pool'.
> (link_path, reparent, switch_cmd, diff):
> Adjust for the above change.
>
> Patch by: kameshj
> ]]]

> Index: subversion/svnserve/serve.c
> ===================================================================
> --- subversion/svnserve/serve.c (revision 23345)
> +++ subversion/svnserve/serve.c (working copy)
> @@ -70,7 +70,7 @@
> /* Verify that URL is inside REPOS_URL and get its fs path. Assume that
> REPOS_URL and URL are already URI-decoded. */
> static svn_error_t *get_fs_path(const char *repos_url, const char *url,
> - const char **fs_path, apr_pool_t *pool)
> + const char **fs_path)
> {
> apr_size_t len;
>
> @@ -502,8 +502,8 @@
> path = svn_path_canonicalize(path, pool);
> url = svn_path_uri_decode(svn_path_canonicalize(url, pool), pool);
> if (!b->err)
> - b->err = get_fs_path(svn_path_uri_decode(b->repos_url, pool), url,
> - &fs_path, pool);
> + b->err = get_fs_path(svn_path_uri_decode(b->repos_url, pool),
> + url, &fs_path);
> if (!b->err)
> b->err = svn_repos_link_path2(b->report_baton, path, fs_path, rev,
> start_empty, lock_token, pool);
> @@ -711,8 +711,8 @@
> SVN_ERR(svn_ra_svn_parse_tuple(params, pool, "c", &url));
> url = svn_path_uri_decode(svn_path_canonicalize(url, pool), pool);
> SVN_ERR(trivial_auth_request(conn, pool, b));
> - SVN_CMD_ERR(get_fs_path(svn_path_uri_decode(b->repos_url, pool), url,
> - &fs_path, pool));
> + SVN_CMD_ERR(get_fs_path(svn_path_uri_decode(b->repos_url, pool),
> + url, &fs_path));
> svn_stringbuf_set(b->fs_path, fs_path);
> SVN_ERR(svn_ra_svn_write_cmd_response(conn, pool, ""));
> return SVN_NO_ERROR;
> @@ -1280,7 +1280,7 @@
> SVN_CMD_ERR(svn_fs_youngest_rev(&rev, b->fs, pool));
> SVN_CMD_ERR(get_fs_path(svn_path_uri_decode(b->repos_url, pool),
> svn_path_uri_decode(switch_url, pool),
> - &switch_path, pool));
> + &switch_path));
>
> return accept_report(conn, pool, b, rev, target, switch_path, TRUE, recurse,
> TRUE);
> @@ -1335,7 +1335,7 @@
> SVN_CMD_ERR(svn_fs_youngest_rev(&rev, b->fs, pool));
> SVN_CMD_ERR(get_fs_path(svn_path_uri_decode(b->repos_url, pool),
> svn_path_uri_decode(versus_url, pool),
> - &versus_path, pool));
> + &versus_path));
>
> return accept_report(conn, pool, b, rev, target, versus_path,
> text_deltas, recurse, ignore_ancestry);
>

> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: dev-help@subversion.tigris.org