[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r23156 - in branches/sparse-directories/subversion: include libsvn_client

From: Karl Fogel <kfogel_at_red-bean.com>
Date: 2007-02-04 06:48:37 CET

On 1/22/07, Daniel Rall <dlr@collab.net> wrote:
> On Mon, 22 Jan 2007, Karl Fogel wrote:
>
> > On 1/22/07, Daniel Rall <dlr@collab.net> wrote:
> > >In libsvn_client/diff.c:do_merge():
> > >
> > > 2145 /* Drive the reporter; do the diff. */
> > > 2146 SVN_ERR(reporter->set_path(report_baton, "", drr.rev1,
> > > 2147 /* ### TODO: dynamic depth here */
> > > 2148 svn_depth_infinity,
> > > 2149 FALSE, NULL,
> > > 2150 pool));
> > >
> > >We have a DEPTH parameter passed in to do_merge(). Do we still not
> > >want to pass it along to the reporter?
> >
> > The issue there (and possibly in some other spots) is that if the
> > caller passes svn_depth_unknown, then we want to sniff the depth
> > from the target working copy and use that. Some places in the
> > code already do this, but not (yet) this one.
>
> The commit message that I was responding to (r23156) introduces such
> sniffing for the WC target of the merge through both code paths which
> excercise do_merge(), svn_client_merge3() svn_client_merge_peg3():

Thanks for the catch -- fixed in r23334.

-K

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Feb 4 06:48:59 2007

This is an archived mail posted to the Subversion Dev mailing list.