[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Status report for Ruby bindings on Windows

From: Joe Swatosh <joe.swatosh_at_gmail.com>
Date: 2007-02-02 05:07:28 CET

Hi kou,

On 2/1/07, Kouhei Sutou <kou@cozmixng.org> wrote:
> Hi,
>
> In <ae6cb1100701312124n3f47adcfr9f35b98ff14d190e@mail.gmail.com>
> "Re: Status report for Ruby bindings on Windows" on Wed, 31 Jan 2007 21:24:30 -0800,
> "Joe Swatosh" <joe.swatosh@gmail.com> wrote:
>
> > > > * Normalizing the line breaks. Upon reflection, I've decided that I
> > > > started us down the wrong path when I modified the tests for the line
> > > > ending issues. As I've thought about it more, I now believe that the
> > > > bindings should do the conversions. My thinking is since Ruby treats
> > > > line endings as "'\n" instead of "\r\n" the bindings should provide
> > > > any multiline values Ruby expects. (This is where the 'b' comes from
> > > > when calling File::open. Without the 'b' on windows there is a \r\n
> > > > to \n conversion. With the 'b', no conversion. Maybe we should check
> > > > out what the Perl and Python bindings do about this issue on
> > > > windows?). (I've made zero effort to figure out what this will take).
> > >
> > > OK. We'll try the problem after we solve test environment
> > > problem on Windows.
> > >
> >
> > Removing all invocations and the definition of normalize_line_break
> > from the test\*.rb files and the attached patch get us:
>
> It seems that the changes make cat ignore svn:eof-style. I
> think tests have a problem. Could you try the attached
> patch?
>
>
> Thanks
> --
> kou
>

The client tests pass with the patch. I (now) still think normalizing
the line breaks in the test is the wrong solution. As you pointed
out, my patch wasn't right for cat, but I hope you'll consider parts
of it, or something like it for the the Core methods. Ruby on windows
uses \n for line breaks, even though windows uses \r\n. This gives us
a real problem to know when to pass the \r through and when not. I'll
see if I can figure out how (and if) the perl bindings deal with the
issue.

Unrelated, please

svn propset svn:eol-style native
subversion\bindings\swig\ruby\test\windows_util.rb

--
Joe
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Feb 2 05:07:44 2007

This is an archived mail posted to the Subversion Dev mailing list.