[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r23303 - in trunk/subversion: include libsvn_subr tests/libsvn_subr

From: C. Michael Pilato <cmpilato_at_collab.net>
Date: 2007-01-31 15:25:47 CET

Peter Lundblad wrote:
>> @@ -116,6 +116,18 @@
>> */
>> char *svn_path_dirname(const char *path, apr_pool_t *pool);
>>
>> +/** Split @c path into a root portion and an extension such that the
>> + * the root + the extension = the original path, and where the
>
> s/@c path/@a path/
> Double "the".

Got it.

>> + last_slash = strrchr(path, '/');
>> + if ((! last_slash) || (last_period > last_slash))
>
> Could simplify by starting looking for the slash at last_period.

Of course! Thanks.

> It would be good to test the combinations with NULL return arguments as
> well.

Good point. Will do.

-- 
C. Michael Pilato <cmpilato@collab.net>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand

Received on Wed Jan 31 15:26:13 2007

This is an archived mail posted to the Subversion Dev mailing list.