[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH]operational logging for checkout and update should log revnum too.

From: Daniel Rall <dlr_at_collab.net>
Date: 2007-01-30 23:06:23 CET

On Mon, 29 Jan 2007, Daniel Rall wrote:
...
> Conceptually, I'm really happy with this patch. I made a few tweaks
> as described below (patch attached).
>
> I do have some concerns about the inconsistency in the format of the
> log output. I've tweaked davautocheck.sh to enable operational
> logging (see the "ops" file); here's a snippet:
>
> [29/Jan/2007:17:28:36 -0800] jrandom diff-or-merge '/' r2:1
> [29/Jan/2007:17:31:35 -0800] jrandom diff-or-merge '/A/B/E/alpha@3' '/A2/B/E/alpha@4'
> [29/Jan/2007:17:00:16 -0800] jrandom switch '/iota@1' '/A/D/gamma@1'
> [29/Jan/2007:17:00:17 -0800] jrandom remote-status '/' r1
> [29/Jan/2007:17:00:19 -0800] jrandom checkout-or-export '/' r1
> [29/Jan/2007:16:59:08 -0800] jrandom update '/' r1
> [29/Jan/2007:17:00:21 -0800] jrandom remote-status '/' r1
> [29/Jan/2007:17:00:21 -0800] jrandom commit r2
> [29/Jan/2007:17:00:22 -0800] jrandom checkout-or-export '/' r1
> [29/Jan/2007:17:00:23 -0800] jrandom unlock '/A/D'
> [29/Jan/2007:17:00:24 -0800] jrandom checkout-or-export '/A/D' r1
> [29/Jan/2007:17:00:27 -0800] jrandom remote-status '/' r1
> [29/Jan/2007:17:00:27 -0800] jrandom unlock '/A/D/gamma'
> [29/Jan/2007:17:30:00 -0800] jrandom list-dir '/A/B/T/'
>
> Several differences in revision specification:
> - Single revision, e.g. r1
> - Revision range, e.g. r2:1
> - Peg revision, e.g. /A/B/E/alpha@3
> - No revision (for lines which probably should include a revision)
>
> Any way we make things a little more consistent?
...

After chatting with Ben on IRC, we reached the conclusion that the
first three cases are necessary to handle our various use cases. The
last case isn't typically meaningful, except for 'lock' and 'unlock'.

I went ahead and implemented revision logging for 'list-dir', and have
committed the patch to trunk.

- Dan

  • application/pgp-signature attachment: stored
Received on Tue Jan 30 23:06:41 2007

This is an archived mail posted to the Subversion Dev mailing list.