[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] make the crash handler optional

From: Stefan Küng <tortoisesvn_at_gmail.com>
Date: 2007-01-30 21:55:26 CET

Daniel Rall wrote:
> On Mon, 29 Jan 2007, Stefan Küng wrote:
>
>> Daniel Rall wrote:
>>
>>> This patch seems conceptually fine. However, I think the crash
>>> handler should be compiled in by default (as it is now); this patch
>>> changes that behavior.
>> Sure. But you can just patch your build scripts and always set that define.
>>
>> My problem right now is that the crash handler part doesn't compile on
>> x64, so my nightly build fails. Even if I exclude the crash* files from
>> the build, the little part in cmdline.c which (right now) is not
>> excluded makes the build fail when linking due to the missing functions
>> (which I excluded from the build).
>
> With Lieven's changes from today, the problematic code should be
> excluded both from being built and from being attached if you undefine
> SVN_USE_WIN32_CRASHHANDLER.
>
> Is this sufficient, Stefan? Or would it be easier if we were treating
> SVN_USE_WIN32_CRASHHANDLER like a boolean?

Sorry for the delay. Had to try the build first.

I can happily report that it works very well! My build now runs through
without patching on x64 compilers too.

Thanks a lot!

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Jan 30 21:55:52 2007

This is an archived mail posted to the Subversion Dev mailing list.