Where does SVN_USE_CRASHHANDLER get defined?
Do we really need both SVN_USE_WIN32_CRASHHANDLER and
SVN_USE_CRASHHANDLER, if the latter is only used when the
SetUnhandledExceptionFilter Windows-only API is invoked?
On Tue, 30 Jan 2007, lgo@tigris.org wrote:
...
> Add a define SVN_USE_WIN32_CRASHHANDLER that enables building the crash
> handler, define it by default.
>
> * subversion/libsvn_subr/cmdline.c
> (svn_cmdline_init): only attach the crash handler when wanted.
>
> * subversion/libsvn_subr/win32_crashrpt.c
> * subversion/libsvn_subr/win32_crashrpt.h
> * subversion/libsvn_subr/win32_crashrpt_dll.h:
> Make the windows crash handler code conditional on the
> SVN_USE_WIN32_CRASHHANDLER define.
>
> * build/generator/gen_win.py
> (get_win_defines): add the SVN_USE_WIN32_CRASHHANDLER define on the
> libsvn_subr target by default.
>
> Modified:
> trunk/build/generator/gen_win.py
> trunk/subversion/libsvn_subr/cmdline.c
> trunk/subversion/libsvn_subr/win32_crashrpt.c
> trunk/subversion/libsvn_subr/win32_crashrpt.h
> trunk/subversion/libsvn_subr/win32_crashrpt_dll.h
>
> Modified: trunk/build/generator/gen_win.py
> URL: http://svn.collab.net/viewvc/svn/trunk/build/generator/gen_win.py?pathrev=23292&r1=23291&r2=23292
> ==============================================================================
> --- trunk/build/generator/gen_win.py (original)
> +++ trunk/build/generator/gen_win.py Tue Jan 30 11:13:52 2007
> @@ -730,6 +730,9 @@
> if self.sasl_path:
> fakedefines.append("SVN_HAVE_SASL")
>
> + if target.name == 'libsvn_subr':
> + fakedefines.append("SVN_USE_WIN32_CRASHHANDLER")
> +
> return fakedefines
>
> def get_win_includes(self, target):
>
> Modified: trunk/subversion/libsvn_subr/cmdline.c
> URL: http://svn.collab.net/viewvc/svn/trunk/subversion/libsvn_subr/cmdline.c?pathrev=23292&r1=23291&r2=23292
> ==============================================================================
> --- trunk/subversion/libsvn_subr/cmdline.c (original)
> +++ trunk/subversion/libsvn_subr/cmdline.c Tue Jan 30 11:13:52 2007
> @@ -105,8 +105,10 @@
> }
> #endif /* _MSC_VER < 1400 */
>
> +#ifdef SVN_USE_CRASHHANDLER
> /* Attach (but don't load) the crash handler */
> SetUnhandledExceptionFilter(svn__unhandled_exception_filter);
> +#endif
>
> #endif /* WIN32 */
>
>
> Modified: trunk/subversion/libsvn_subr/win32_crashrpt.c
> URL: http://svn.collab.net/viewvc/svn/trunk/subversion/libsvn_subr/win32_crashrpt.c?pathrev=23292&r1=23291&r2=23292
> ==============================================================================
> --- trunk/subversion/libsvn_subr/win32_crashrpt.c (original)
> +++ trunk/subversion/libsvn_subr/win32_crashrpt.c Tue Jan 30 11:13:52 2007
> @@ -17,6 +17,7 @@
> */
>
> #ifdef WIN32
> +#ifdef SVN_USE_WIN32_CRASHHANDLER
>
> /*** Includes. ***/
> #include <windows.h>
> @@ -779,4 +780,5 @@
> /* terminate the application */
> return EXCEPTION_EXECUTE_HANDLER;
> }
> +#endif /* SVN_USE_WIN32_CRASHHANDLER */
> #endif /* WIN32 */
>
> Modified: trunk/subversion/libsvn_subr/win32_crashrpt.h
> URL: http://svn.collab.net/viewvc/svn/trunk/subversion/libsvn_subr/win32_crashrpt.h?pathrev=23292&r1=23291&r2=23292
> ==============================================================================
> --- trunk/subversion/libsvn_subr/win32_crashrpt.h (original)
> +++ trunk/subversion/libsvn_subr/win32_crashrpt.h Tue Jan 30 11:13:52 2007
> @@ -20,9 +20,11 @@
> #define SVN_LIBSVN_SUBR_WIN32_CRASHRPT_H
>
> #ifdef WIN32
> +#ifdef SVN_USE_WIN32_CRASHHANDLER
>
> LONG WINAPI svn__unhandled_exception_filter(PEXCEPTION_POINTERS ptrs);
>
> +#endif /* SVN_USE_WIN32_CRASHHANDLER */
> #endif /* WIN32 */
>
> #endif /* SVN_LIBSVN_SUBR_WIN32_CRASHRPT_H */
>
> Modified: trunk/subversion/libsvn_subr/win32_crashrpt_dll.h
> URL: http://svn.collab.net/viewvc/svn/trunk/subversion/libsvn_subr/win32_crashrpt_dll.h?pathrev=23292&r1=23291&r2=23292
> ==============================================================================
> --- trunk/subversion/libsvn_subr/win32_crashrpt_dll.h (original)
> +++ trunk/subversion/libsvn_subr/win32_crashrpt_dll.h Tue Jan 30 11:13:52 2007
> @@ -20,6 +20,7 @@
> #define SVN_LIBSVN_SUBR_WIN32_CRASHRPT_DLL_H
>
> #ifdef WIN32
> +#ifdef SVN_USE_WIN32_CRASHHANDLER
>
> /* public functions in dbghelp.dll */
> typedef BOOL (WINAPI * MINIDUMPWRITEDUMP)(HANDLE hProcess, DWORD ProcessId,
> @@ -92,6 +93,7 @@
> SYMFUNCTIONTABLEACCESS SymFunctionTableAccess_;
> SYMGETMODULEBASE SymGetModuleBase_;
>
> +#endif /* SVN_USE_WIN32_CRASHHANDLER */
> #endif /* WIN32 */
>
> #endif /* SVN_LIBSVN_SUBR_WIN32_CRASHRPT_DLL_H */
> \ No newline at end of file
- application/pgp-signature attachment: stored
Received on Tue Jan 30 21:05:37 2007