[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Recursion of copy_source_ops() causes stack overflow in Apache

From: Daniel Rall <dlr_at_collab.net>
Date: 2007-01-30 01:24:36 CET

On Mon, 29 Jan 2007, Daniel Berlin wrote:
...
> >[Oh, there definitely should be a hard maximum recursion depth for
> >copy_source_ops(), though I don't know what it is, and it might be quite
> >large. The operation definitely isn't unbounded.]
>
> Errr, why not just remove the c-stack and turn the thing into a while
> loop using a pool-allocated stack?

That seems like a reasonable way to go. This way, if we overflow,
we're *really* out of memory (heap), instead of just out of stack
space.

  • application/pgp-signature attachment: stored
Received on Tue Jan 30 03:49:54 2007

This is an archived mail posted to the Subversion Dev mailing list.