[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r23240 - trunk/subversion/svn

From: Hyrum K. Wright <hyrum_wright_at_mail.utexas.edu>
Date: 2007-01-27 19:59:43 CET

Malcolm Rowe wrote:
> On Thu, Jan 25, 2007 at 07:05:57PM -0800, hwright@tigris.org wrote:
>> Modified: trunk/subversion/svn/cl.h
>> +/* Print the XML header to stdout, using TAGNAME as the openning tag.
>> + Use pool for temporary allocations. */
>> +svn_error_t *svn_cl__xml_print_header(const char *tagname,
>> + apr_pool_t *pool);
>> +
>> +/* Print the XML footer to stdout, using TAGNAME for the closing tag.
>> + Use pool for temporary allocations. */
>> +svn_error_t *svn_cl__xml_print_footer(const char *tagname,
>> + apr_pool_t *pool);
>> +
>
> I think we might be a bit clearer about what the 'header' and 'footer'
> represent, in this case, the XML prolog and document root element
> start-tag, and the root element end-tag respectively.
>
>> Modified: trunk/subversion/svn/util.c
>> +svn_error_t *
>> +svn_cl__xml_print_header(const char *tagname,
>> + apr_pool_t *pool)
>> +{
>> + svn_stringbuf_t *sb = svn_stringbuf_create("", pool);
>> +
>> + /* <?xml version="1.0" encoding="utf-8"?> */
>> + svn_xml_make_header(&sb, pool);
>
> I know you just copied that comment, but it's actually been out of date
> since r18931.

Thanks for pointing these out. I've clarified the comments in r23270.

-Hyrum

Received on Sat Jan 27 20:00:33 2007

This is an archived mail posted to the Subversion Dev mailing list.