[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] JavaHL changelist support

From: Hyrum K. Wright <hyrum_wright_at_mail.utexas.edu>
Date: 2007-01-25 21:57:56 CET

Ben Collins-Sussman wrote:
> On 1/25/07, Hyrum K. Wright <hyrum_wright@mail.utexas.edu> wrote:
>
>> svn_client_set_changelist() takes a changelist name and returns an array
>> of paths which belong to that changelist.
>
> No, it's a set function, not a get function. :-)
>
> svn_client _set_changelist() takes an array of paths, and assigns them
> to a changelist.
>
> svn_client_retrieve_changelist() takes a changelist name and returns
> all paths that belong to it.
> (This is currently done by an expensive crawl over the whole working copy.)

Uh. That's what I meant. :)

>> I don't think there is an API
>> which lists which changelist a file belongs to
>
> I don't think we need an API for that; just fetch the file's
> svn_wc_entry_t and look at entry->changelist.
>
>> nor one which lists all
>> the changelists which are currently in the WC. Maybe sussman can
>> comment on the feasibility of adding such.
>
> I suppose we could add such an API, wouldn't be too hard, but again,
> would be an expensive crawl over the whole working copy.
>
> As Mark Phippard suggests, this is what the svn commandline-client's
> own status code is already doing: 'svn status' already crawls over
> the working copy and return svn_wc_entry_t objects; all I did was
> make this code notice any entry->changelist values it encountered, and
> then group the display by changelist. Presumably other svn clients
> would do the same thing.
>
> Another caveat, however: it sounds like kfogel and others would like
> me to redesign the API a wee bit, so if you're busy porting this
> feature to JavaHL, be prepared for the possibility of a bit of flux.

That's fine. I just wanted to get them in there so we don't forget
later on. Thanks for the heads up on the possible moving target.

-Hyrum

Received on Thu Jan 25 21:58:15 2007

This is an archived mail posted to the Subversion Dev mailing list.