[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] JavaHL changelist support

From: Hyrum K. Wright <hyrum_wright_at_mail.utexas.edu>
Date: 2007-01-25 20:36:40 CET

Mark Phippard wrote:
> On 1/25/07, Hyrum K. Wright <hyrum_wright@mail.utexas.edu> wrote:
>>
>> Mark Phippard wrote:
>> > On 1/25/07, Hyrum K. Wright <hyrum_wright@mail.utexas.edu> wrote:
>> >>
>> >> I've gone ahead and added changelist support to the JavaHL bindings.
>> >> Being my first time to do some non-trivial JavaHL hacking, I just want
>> >> to make sure I'm not missing anything in the attached patch. If
>> nobody
>> >> objects, I'll commit this in the next few days.
>> >
>> >
>> > I have not looked at the changelist stuff too much. Would it be
>> > possible to
>> > have API's to list the changesets that have been created, the files in
>> that
>> > changeset and then I would guess an API to remove a file from a
>> changeset?
>> > I think we would need stuff like this if we were ever going to use them
>> > from
>> > Subclipse.
>>
>> The only other changelist API is svn_client_set_changelist(), which we
>> could add support for as well. (To remove a file from a changelist,
>> just set the changelist name to "".) Set the changelist is a little bit
>> easier than retrieving it, and I wanted to make sure I remembered to add
>> everything that JavaHL needs, hence the reason for this patch.
>
>
> If we realistically wanted to use this API in Subclipse we would likely
> need
> to maintain our "own database" of what files are in what changeset. This
> would defeat the point of using the API, as that would mean we would not
> know about things that other clients did with the same WC.
>
> Realistically, we would probably need an API to list what files are in what
> changesets. Maybe that would be a new usage of the status API or new data
> available in the current one? I think that is how the CLI is doing it.

svn_client_set_changelist() takes a changelist name and returns an array
of paths which belong to that changelist. I don't think there is an API
which lists which changelist a file belongs to, nor one which lists all
the changelists which are currently in the WC. Maybe sussman can
comment on the feasibility of adding such.

(Note that my knowledge of the changelist feature is pretty shallow.
I'm just trying to plug holes in the bindings.)

-Hyrum

Received on Thu Jan 25 20:36:58 2007

This is an archived mail posted to the Subversion Dev mailing list.