[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: bug in repos_replay

From: Vlad Georgescu <vgeorgescu_at_gmail.com>
Date: 2007-01-25 18:37:59 CET

David Glasser wrote:
> On 1/25/07, David Glasser <glasser@mit.edu> wrote:
>> In fact, now that I think about it, I'm not convinced that this
>> "handle things in add_subdir and make path_driver_cb_func ignore it"
>> function is correct anyway, even if it happens to work; won't
>> svn_delta_path_driver end up calling a bunch of open_directories to
>> get to the things that we've ignored?
>
> Yeah, I've tested current trunk with the debug_editor. Looks like
> while we've cured the symptom of "producing bad editor call sequence
> which confuses the commit editor", we haven't actually made the call
> sequence completely legal.

FWIW, I just realized that the initial errors were caused not by the
editor call sequence, but by path_driver_cb_func trying to send the
nested modifications as deltas against the previous revision.

This explains the "File not found: revision 1, path '/A/P/lambda'"
errors: path_driver_cb_func doesn't realize that /A/P/lambda was copied
from somewhere else so it tries to list the properties it had in revision 1.

Of course, we still have the editor ordering problem, but I'm not sure
how it can be fixed.

-- 
Vlad
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Jan 25 18:38:24 2007

This is an archived mail posted to the Subversion Dev mailing list.