[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r23190 - trunk/subversion/libsvn_client

From: Kobayashi Noritada <nori1_at_dolphin.c.u-tokyo.ac.jp>
Date: 2007-01-25 08:36:24 CET

Hi,

> Author: dlr
> Date: Tue Jan 23 12:49:42 2007
> New Revision: 23190
>
> Log:
> Improve error message for 'svn move'.
>
> * subversion/libsvn_client/copy.c
> (setup_copy): Improve error message used when a repository -> WC
> move is attempted.
>
>
> Modified:
> trunk/subversion/libsvn_client/copy.c

> /* Disallow moves between the working copy and the repository. */
> return svn_error_create
> (SVN_ERR_UNSUPPORTED_FEATURE, NULL,
> - _("No support for repos <--> working copy moves"));
> + _("Repository to working copy moves are not supported"));

The previous message and comment (and code) seems to be for WC->repos
moves as well as for repos->WC ones, although the committed message is
only for the latter. Should we make the message something like this?

"Moves between the working copy and the repository are not supported"

If my code review is not careful, or I have some misunderstanding,
sorry.

-nori

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Jan 25 08:36:42 2007

This is an archived mail posted to the Subversion Dev mailing list.