[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: bug in repos_replay

From: David Glasser <glasser_at_mit.edu>
Date: 2007-01-24 20:43:35 CET

On 1/24/07, David Glasser <glasser@mit.edu> wrote:
> Does anyone know of other places in the code where we need to combine
> an svn_delta_path_driver traversal with other editor calls that might
> be somewhat out of sequence? It looks like this is asking for an "add
> entries to the list that svn_delta_path_driver is running through"
> API, though that might be overengineering.

Hmm, here's a possibility: svn_delta_path_driver drives
path_driver_cb_func, which finds out what the change it is simulating
is via the changed_paths hash in its baton.

path_driver_cb_func could provide changed_paths to add_subdir. If
add_subdir notices that one of the files or directories it is adding
has a changed_path entry, then it can call path_driver_cb_func itself.
 (We can make path_driver_cb_func erase its entry in changed_paths
after processing it so that things don't happen twice.)

This feels very dirty, though. Does anyone have an opinion? (It also
probably wouldn't work for newly added files inside the copied
directory, I guess, unless you actually throw in a loop over
changed_paths. Ick.)


David Glasser | glasser_at_mit.edu | http://www.davidglasser.net/
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Jan 24 20:43:54 2007

This is an archived mail posted to the Subversion Dev mailing list.