[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r23188 - in branches/perl-bindings-improvements: . subversion/bindings/swig/perl/native subversion/bindings/swig/perl/native/t

From: Daniel Rall <dlr_at_collab.net>
Date: 2007-01-23 21:09:54 CET

On Tue, 23 Jan 2007, nikclayton@tigris.org wrote:

> Author: nikclayton
> Date: Tue Jan 23 10:14:29 2007
> New Revision: 23188
>
> Log:
> Adjust checkout() with named and optional parameter support.
>
> [in subversion/bindings/swig/perl/native]
>
> * Client.pm: Remove checkout from the list of general functions and
> add it to the list of the functions that take named params. Provide
> a Params::Validate parameter specification. Adjust the checkout
> documentation accordingly.

Nice log message. We typical list symbol names like this in the
change log so that they're really obvious:

* Client.pm
  (checkout): ...

...
> --- branches/perl-bindings-improvements/subversion/bindings/swig/perl/native/Client.pm (original)
> +++ branches/perl-bindings-improvements/subversion/bindings/swig/perl/native/Client.pm Tue Jan 23 10:14:29 2007
...
> @@ -312,7 +314,14 @@
> other kind that requires a local path), then an error will be raised,
> because the desired revision can not be determined.
>
> -=item $ctx-E<gt>checkout($url, $path, $revision, $recursive, $pool);
> +=item $ctx-E<gt>checkout
> +
> + my $revision = $ctx->checkout({
> + url => '...',
> + path => '...',
> + revision => $revision, # optional, default is 'HEAD'
> + recurse => $recursive, # optional, default is 0
> + });
...

Any particular reason to remove the POD for the old calling style
(e.g. named params are preferred)?

  • application/pgp-signature attachment: stored
Received on Tue Jan 23 21:10:10 2007

This is an archived mail posted to the Subversion Dev mailing list.