[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] --native-eol option support for checkout and update, fixed version

From: Lieven Govaerts <svnlgo_at_mobsol.be>
Date: 2007-01-23 17:08:42 CET

Quoting Pavel Fedin <sonic_amiga@rambler.ru>:

> Hello all!
> This is the second version of the patch. This version fixes the
> serious bug: --native-eol was previously forced for all files and this
> broke binary files in the repository. Now --native-eol is applied only
> to files with "svn:eol-style" property set to "native".
> The patch applies to 1.4.2 release.

I can't comment on the merits of your patch, but I'd like you (or anyone else
interested in this feature) to provide associated (python) regression tests.
Providing regression tests will not only help us not to break this feature in
the future, but also it provides a detailed spec of how this feature is
supposed to behave.

While this is not a strict policy, I personally will not commit a patch for a
new feature that doesn't include regression tests.
BTW, I'm not saying that *you* should provide those tests, if you can't or you
need some help let me know.

regards,

Lieven

----------------------------------------------------------------
This message was sent using IMP, the Internet Messaging Program.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Jan 23 17:09:26 2007

This is an archived mail posted to the Subversion Dev mailing list.