[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r22957 - trunk/subversion/libsvn_client

From: Daniel Rall <dlr_at_collab.net>
Date: 2007-01-22 23:25:47 CET

On Sun, 21 Jan 2007, Vlad Georgescu wrote:

> Hi,
>
> hwright@tigris.org wrote:
> [...]
> > + err = setup_copy(commit_info_p,
> > + src_paths, src_revision,
> > + svn_path_join(dst_path, src_basename, pool),
> > + FALSE /* is_move */,
> > + TRUE /* force, set to avoid deletion check */,
> > + ctx,
> > + subpool);
> > }
> >
> > + svn_pool_destroy(subpool);
> > +
>
> Looks like you're destroying the pool in which *commit_info_p was
> allocated. (I compile APR with --enable-pool-debug, which makes it much
> more likely that these kinds of problems will cause a segfault later on).
>
> [...]
> > + err = setup_copy(commit_info_p, src_paths, &src_revision,
> > + svn_path_join(dst_path, src_basename, pool),
> > + TRUE /* is_move */,
> > + force,
> > + ctx,
> > + subpool);
> > }
> >
> > + svn_pool_destroy(subpool);
> > +
> > return err;
> > }
>
> Same here.

Thanks Vlad, taken care of.

  • application/pgp-signature attachment: stored
Received on Mon Jan 22 23:26:10 2007

This is an archived mail posted to the Subversion Dev mailing list.