[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r23110 - in branches/perl-bindings-improvements: . subversion/bindings/swig/perl/native/t

From: Daniel Rall <dlr_at_collab.net>
Date: 2007-01-19 20:53:03 CET

This wouldn't be a problem in 1.4.x (and lower), unless you turned on
SVN_DEBUG_ERROR (the behavior of which is now on by default in trunk
when you configure with --enable-maintainer-mode).

On Fri, 19 Jan 2007, nikclayton@tigris.org wrote:

> Author: nikclayton
> Date: Fri Jan 19 11:33:16 2007
> New Revision: 23110
>
> Log:
> Explicitly clear an error to avoid a coredump if built with
> --enable-maintainer-mode.
>
> * subversion/bindings/swig/perl/native/t/3client.t: After testing to see if
> an error was generated (when testing error generation), explicitly clear
> the generated error. This fixes an abort introduced in r22934 if you
> run this test with --enable-maintainer-mode. The test ran to completion
> (all tests pass), but the Perl interpreter aborts at END time. This was
> not considered a test failure.
>
> Add an additional test in the END block. This should always succeed,
> and serves to prove that the END block ran.
>
>
> Modified:
> branches/perl-bindings-improvements/ (props changed)
> branches/perl-bindings-improvements/subversion/bindings/swig/perl/native/t/3client.t
>
> Modified: branches/perl-bindings-improvements/subversion/bindings/swig/perl/native/t/3client.t
> URL: http://svn.collab.net/viewvc/svn/branches/perl-bindings-improvements/subversion/bindings/swig/perl/native/t/3client.t?pathrev=23110&r1=23109&r2=23110
> ==============================================================================
> --- branches/perl-bindings-improvements/subversion/bindings/swig/perl/native/t/3client.t (original)
> +++ branches/perl-bindings-improvements/subversion/bindings/swig/perl/native/t/3client.t Fri Jan 19 11:33:16 2007
> @@ -1,6 +1,6 @@
> #!/usr/bin/perl -w
>
> -use Test::More tests => 118;
> +use Test::More tests => 119;
> use strict;
>
> # shut up about variables that are only used once.
> @@ -179,9 +179,11 @@
> undef,
> 'info should return undef');
>
> -isa_ok($ctx->info("$wcpath/dir1/newxyz", undef, 'WORKING', sub {}, 0),
> - '_p_svn_error_t',
> +my $r = $ctx->info("$wcpath/dir1/newxyz", undef, 'WORKING', sub {}, 0);
> +isa_ok($r, '_p_svn_error_t',
> 'info should return _p_svn_error_t for a nonexistent file');
> +$r->clear(); # Clear the error, avoid core dump
> + # if built with --enable-maintainer-mode
>
> # test getting the log
> is($ctx->log("$reposurl/dir1/new",$current_rev,$current_rev,1,0,
> @@ -446,4 +448,5 @@
> END {
> diag('cleanup');
> rmtree($testpath);
> +pass('END block ran through to completion');
> }
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: svn-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: svn-help@subversion.tigris.org

  • application/pgp-signature attachment: stored
Received on Fri Jan 19 20:53:19 2007

This is an archived mail posted to the Subversion Dev mailing list.