[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[PATCH] Re: slash after dir in bash_completion

From: Martin von Gagern <Martin.vGagern_at_gmx.net>
Date: 2007-01-17 10:49:54 CET

Hyrum K. Wright wrote:
> Martin,
> I have not reviewed your patch, however, I do have a suggestion. Your
> patch a much greater probability of being applied if you follow the
> guidelines in HACKING, especially regarding subject lines and log
> messages.
> Thanks,
> -Hyrum

OK, so here we go again. The same patch minus the trunk/ prefix plus the
log message, and PATCH in the subject line. Thanks for the hint, Hyrum!

For the verbose description of the problem as well as for some
discussion of alternatives I'd point readers at my original post:
The important thing is in the log message as well, of course.


* tools/client-side/bash_completion: Tell besh we are generating filenames
  so that it puts a slash instead of a space after a directory name.

Index: tools/client-side/bash_completion
--- tools/client-side/bash_completion (revision 23051)
+++ tools/client-side/bash_completion (working copy)
@@ -616,7 +616,7 @@
         COMPREPLY=( $( compgen -W "$cmdOpts" -- $cur ) )
         return 0
-complete -F _svn -o default svn
+complete -F _svn -o filenames svn
 _svnadmin ()
@@ -717,4 +717,4 @@
         return 0
-complete -F _svnadmin -o default svnadmin
+complete -F _svnadmin -o filenames svnadmin

Received on Wed Jan 17 10:50:04 2007

This is an archived mail posted to the Subversion Dev mailing list.