[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: [PATCH] subversion/libsvn_subr/io.c missing EPERM definition

From: Miller, Eric <Eric.Miller_at_amd.com>
Date: 2007-01-16 18:05:54 CET

> From: Daniel Rall [mailto:dlr@collab.net]
> Sent: Monday, January 15, 2007 11:57 AM
> To: Miller, Eric
> Cc: D.J. Heap; Bakke, Steven; dev@subversion.tigris.org
> Subject: Re: [PATCH] subversion/libsvn_subr/io.c missing EPERM
definition
>
> Thanks Eric. I've committed a tweaked version of your patch to trunk,
> and nominated it for backport to the 1.4.3 release.
>
> - Dan

> From: C. Michael Pilato [mailto:cmpilato@collab.net]
> Sent: Tuesday, January 16, 2007 9:36 AM
> To: Miller, Eric
> Cc: D.J. Heap; Bakke, Steven; dev@subversion.tigris.org
> Subject: Re: File permissions problems with 1.4.0 (yet again!)
>
> I'm totally not following this thread, so forgive me if I'm adding
> nothing but noise to it. But glancing at the code, I'm wondering if
the
> correct fix is *not* to add
>
> #include <errno.h>
>
> to io.c, but instead to simply move the #ifndef APR_STATUS_IS_EPERM
> block to *after* the inclusion of the APR headers. Most of the APR
> headers already include apr_errno.h, which includes errno.h on
platforms
> that have it.
>
> --
> C. Michael Pilato <cmpilato@collab.net>
> CollabNet <> www.collab.net <> Distributed Development On
Demand

Makes sense to me. I was trying to undo a change that modified previous
behavior. This seems like the proper fix.

Dan, is this the tweak you made? If not, I have attached the new patch.

Eric

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Received on Tue Jan 16 18:06:14 2007

This is an archived mail posted to the Subversion Dev mailing list.