[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r23017 - trunk/subversion/libsvn_client

From: Daniel Rall <dlr_at_collab.net>
Date: 2007-01-15 22:19:34 CET

On Mon, 15 Jan 2007, Karl Fogel wrote:

> On 1/15/07, dlr@tigris.org <dlr@tigris.org> wrote:
> >Author: dlr
> >Date: Mon Jan 15 10:24:15 2007
> >New Revision: 23017
> >
> >Log:
> >Reduce lifetime/size of memory footprint for 'proplist'.
> >
> >* subversion/libsvn_client/prop_commands.c
> > (svn_client_proplist2): Destroy sub-pool after use.
>
> The log message is a little misleading -- it implies that the subpool
> was always there, and that we'd just been forgetting to destroy it :-).

Good, because that's exactly what was happening. :-)

We created the sub-pool (without keeping a reference to it in a local
variable), but never destroyed it.

...
> >--- trunk/subversion/libsvn_client/prop_commands.c (original)
> >+++ trunk/subversion/libsvn_client/prop_commands.c Mon Jan 15
> >10:24:15 2007
...
> >@@ -1112,7 +1113,8 @@
> >
> > SVN_ERR(remote_proplist(*props, url, "",
> > kind, revnum, ra_session,
> >- recurse, pool, svn_pool_create(pool)));
> >+ recurse, pool, subpool));
> >+ svn_pool_destroy(subpool);
> > }

  • application/pgp-signature attachment: stored
Received on Mon Jan 15 23:10:56 2007

This is an archived mail posted to the Subversion Dev mailing list.