On Mon, 15 Jan 2007, Karl Fogel wrote:
> On 1/15/07, email@example.com <firstname.lastname@example.org> wrote:
> >Author: dlr
> >Date: Mon Jan 15 10:24:15 2007
> >New Revision: 23017
> >Reduce lifetime/size of memory footprint for 'proplist'.
> >* subversion/libsvn_client/prop_commands.c
> > (svn_client_proplist2): Destroy sub-pool after use.
> The log message is a little misleading -- it implies that the subpool
> was always there, and that we'd just been forgetting to destroy it :-).
Good, because that's exactly what was happening. :-)
We created the sub-pool (without keeping a reference to it in a local
variable), but never destroyed it.
> >--- trunk/subversion/libsvn_client/prop_commands.c (original)
> >+++ trunk/subversion/libsvn_client/prop_commands.c Mon Jan 15
> >10:24:15 2007
> >@@ -1112,7 +1113,8 @@
> > SVN_ERR(remote_proplist(*props, url, "",
> > kind, revnum, ra_session,
> >- recurse, pool, svn_pool_create(pool)));
> >+ recurse, pool, subpool));
> >+ svn_pool_destroy(subpool);
> > }
Received on Mon Jan 15 23:10:56 2007
- application/pgp-signature attachment: stored