Thanks Eric. I've committed a tweaked version of your patch to trunk,
and nominated it for backport to the 1.4.3 release.
- Dan
On Mon, 15 Jan 2007, Miller, Eric wrote:
> Fix to allow permission changes via reown_file().
>
> * subversion/libsvn_subr/io.c
> Commit r17501 inadvertently removed support for the EPERM error code
> from apr_file_perms_set(). This in turn prevented attempt at file
> reownership via reown_file() and errored with 'cannot change
> permissions'.
>
> I believe this bug was introduced between the 1.3.2 and 1.4.0 releases.
>
> Eric
Content-Description: io.c.patch
> [-- octet-filter file type: "ASCII English text" --]
>
> [-- Statistics (lines words chars): 21 75 687 /tmp/io.c.patch --]
>
> [[[
> Fix to allow permission changes via reown_file().
>
> * subversion/libsvn_subr/io.c
> Commit r17501 inadvertently removed support for the EPERM error code from apr_file_perms_set(). This in turn prevented attempt at file reownership via reown_file() and errored with 'cannot change permissions'.
>
> I believe this bug was introduced between the 1.3.2 and 1.4.0 releases.
>
> ]]
> Index: subversion/libsvn_subr/io.c
> ===================================================================
> --- subversion/libsvn_subr/io.c (revision 23013)
> +++ subversion/libsvn_subr/io.c (working copy)
> @@ -23,6 +23,7 @@
>
> #ifndef WIN32
> #include <unistd.h>
> +#include <errno.h>
> #endif
>
> #ifndef APR_STATUS_IS_EPERM
- application/pgp-signature attachment: stored
Received on Mon Jan 15 21:03:27 2007