[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [CONTRIB] remove-zombie-locks.py, workaround for Issue #2507

From: C. Michael Pilato <cmpilato_at_collab.net>
Date: 2007-01-11 03:42:18 CET

Nathan Kidd wrote:
> However, we have had a huge benefit from CollabNet's Subversion
> sponsorship, so if you really think you'll get a tangible benefit from
> it I don't mind to use the Subversion license.

Ultimately this is your call, dude. Please reply to this mail with a
clear determination of what you wish the license to be. Or, better yet,
resubmit the patch with the desired license present. I'll watch for the
mail, test the functionality, and hopefully commit the code shortly
thereafter.

I don't want license garbage getting in the way of others being able to
use a script that appears, at first glance, to be as well-written as
yours does.

One comment I had in a follow-up code review:

> def main(repos_path, repos_rev):
> repos_path = os.path.abspath(repos_path)
> if repos_rev.lower() == "all":
> remover = RepositoryZombieLockRemover(repos_path, "")
> else:
> repos_rev = int(repos_rev)
> remover = RevisionZombieLockRemover(repos_path, repos_rev)

You might wanna wrap that int(repos_rev) in try/except, failing to the
usage message.

-- 
C. Michael Pilato <cmpilato@collab.net>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand

Received on Thu Jan 11 03:42:29 2007

This is an archived mail posted to the Subversion Dev mailing list.