[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r22957 - trunk/subversion/libsvn_client

From: Hyrum K. Wright <hyrum_wright_at_mail.utexas.edu>
Date: 2007-01-10 18:28:10 CET

Malcolm Rowe wrote:
> On Wed, Jan 10, 2007 at 09:05:25AM -0800, hwright@tigris.org wrote:
>> Log:
>> Use a subpool for copy and move operations. If the copy or move fails, and the
>> *_as_child flag is set, we try again. By adding this subpool, we make sure
>> that the memory from the first try (as well as the second) is cleared.
>>
>
> That's not a typical use of a subpool, unless we have reason to believe
> that the setup_copy() operation will allocate a significant amount of
> memory.

I don't have any figures, and I'm not sure what the threshold is for "a
significant amount", but my feeling is that the amount of memory isn't
trivial.

If this is wrong, though, I'm happy to revert.

-Hyrum

Received on Wed Jan 10 18:28:27 2007

This is an archived mail posted to the Subversion Dev mailing list.