[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH][merge-tracking]Remove svn_fs_merge_info__create_index thanks to r22885

From: Malcolm Rowe <malcolm-svn-dev_at_farside.org.uk>
Date: 2007-01-04 23:23:33 CET

On Thu, Jan 04, 2007 at 11:20:24AM -0800, Daniel Rall wrote:
> I'm not sure about this. I like the fact that 'svnadmin create'
> attempts to create the sqlite merge info index, and think that it
> should continue to do so, on the grounds that it provides a "fail
> fast" behavior.
>

There's arguments for both ways, I think. Creating the index on-demand
means that we get the same code path and behaviour for repositories that
are upgraded and those that are created with 1.5, for example.

But why not remove the explicit creation logic and just exercise the
on-demand code at creation time (by running a dummy query). That way,
you get the benefit of failure at repository creation time together with
a single code path to test.

Alternatively, keep the explicit creation - it's really not that much
code.

Regards,
Malcolm

  • application/pgp-signature attachment: stored
Received on Thu Jan 4 23:23:43 2007

This is an archived mail posted to the Subversion Dev mailing list.