[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH]operational logging for checkout and update should log revnum too.

From: Daniel Rall <dlr_at_collab.net>
Date: 2007-01-04 20:40:52 CET

I responded to this patch on Fri, 29 Dec:

  http://subversion.tigris.org/servlets/ReadMsg?listName=dev&msgNo=122483

I'm basically waiting for a response and/or adjusted patch, but do
think something like this should be committed.

Kamesh sent in another similar patch as well:

  http://subversion.tigris.org/servlets/ReadMsg?listName=dev&msgNo=122383

I like the idea of this one too, but haven't tested it out. It would
be great if 'davautocheck' would activate operational logging, and we
had tests which validated that the log file was getting written as
expected. I'm not sure how this would work with vanilla 'davcheck' --
perhaps we just start requiring that operational logging be active?

- Dan

On Thu, 04 Jan 2007, Hyrum K. Wright wrote:

> Kamesh Jayachandran wrote:
> > Hi All,
> > Find the attached patch and log.
> >
> > With regards
> > Kamesh Jayachandran
>
> Ping...
>
> Anybody had a chance to look at this yet? I'll file an issue if nothing
> happens in the next few days.
>
> -Hyrum
>
> > ------------------------------------------------------------------------
> >
> > [[[
> >
> > Checkout/export and Update should should log the revnum too.
> >
> > * subversion/mod_dav_svn/reports/update.c
> > (dav_svn__update_report):
> > Log revnum for checkout/export and update.
> >
> > Patch by: kameshj
> > Suggested by: Honey George <george@collab.net>
> >
> > ]]]
> >
> >
> > ------------------------------------------------------------------------
> >
> > Index: subversion/mod_dav_svn/reports/update.c
> > ===================================================================
> > --- subversion/mod_dav_svn/reports/update.c (revision 22777)
> > +++ subversion/mod_dav_svn/reports/update.c (working copy)
> > @@ -1280,15 +1280,16 @@
> > reports it (and it alone) to the server as being empty. */
> > if (entry_counter == 1 && entry_is_empty)
> > action = apr_psprintf(resource->pool,
> > - "checkout-or-export '%s'",
> > - svn_path_uri_encode(spath, resource->pool));
> > + "checkout-or-export '%s' r%" SVN_REVNUM_T_FMT,
> > + svn_path_uri_encode(spath, resource->pool),
> > + revnum);
> > else
> > {
> > if (text_deltas)
> > action = apr_psprintf(resource->pool,
> > - "update '%s'",
> > - svn_path_uri_encode(spath,
> > - resource->pool));
> > + "update '%s' r%" SVN_REVNUM_T_FMT,
> > + svn_path_uri_encode(spath, resource->pool),
> > + revnum);
> > else
> > action = apr_psprintf(resource->pool,
> > "remote-status '%s'",
>

  • application/pgp-signature attachment: stored
Received on Thu Jan 4 20:40:53 2007

This is an archived mail posted to the Subversion Dev mailing list.