[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Peg Revision Syntax

From: Hyrum K. Wright <hyrum_wright_at_mail.utexas.edu>
Date: 2007-01-03 23:42:00 CET

C. Michael Pilato wrote:
> Hyrum K. Wright wrote:
>> Ben Collins-Sussman wrote:
>>> On 1/3/07, Hyrum K. Wright <hyrum_wright@mail.utexas.edu> wrote:
>>>
>>>> +svn_error_t *
>>>> +svn_client__resolve_revisions(svn_opt_revision_t *peg_rev,
>>>> + svn_opt_revision_t *op_rev,
>>>> + svn_boolean_t is_url)
>>>> +{
>>>> + if (peg_rev->kind == svn_opt_revision_unspecified)
>>>> + {
>>>> + if (is_url)
>>>> + peg_rev->kind = svn_opt_revision_head;
>>>> + else
>>>> + peg_rev->kind = svn_opt_revision_base;
>> ^
>> Hmmm...on second thought, should this be svn_opt_revision_working, to
>> make sure that we pick up local modifications?
>
> Maybe add a notice_local_mods parameter to help decide between BASE and
> WORKING?

"Let the caller decide." Quite a novel concept! ;)

Thanks for the suggestion, Mike. I'll make the change shortly.

-Hyrum

Received on Wed Jan 3 23:42:13 2007

This is an archived mail posted to the Subversion Dev mailing list.