Re: Peg Revision Syntax

Ben Collins-Sussman wrote:
> On 1/3/07, Hyrum K. Wright <hyrum_wright@mail.utexas.edu> wrote:
>
>> +svn_error_t *
>> +svn_client__resolve_revisions(svn_opt_revision_t *peg_rev,
>> + svn_opt_revision_t *op_rev,
>> + svn_boolean_t is_url)
>> +{
>> + if (peg_rev->kind == svn_opt_revision_unspecified)
>> + {
>> + if (is_url)
>> + peg_rev->kind = svn_opt_revision_head;
>> + else
>> + peg_rev->kind = svn_opt_revision_base;
>> + }
>> +
>> + if (op_rev->kind == svn_opt_revision_unspecified)
>> + op_rev->kind = peg_rev->kind;
>> +
>> + return SVN_NO_ERROR;
>> +}
>> +
>
>
> It looks right to me! Are you thinking of making all subcommands use
> this function?

Yes, at least all the subcommands which support peg revs.

> We really need a bunch of tests for pegrev/oprevs. :-)

Agreed. Hopefully someone will write some. :)

-Hyrum