Re: [PATCH] Linking the Ruby bindings on windows

Hi Daniel,

On 1/2/07, Daniel Rall <dlr@collab.net> wrote:
> On Sat, 30 Dec 2006, Joe Swatosh wrote:
>
> > On 12/29/06, Joe Swatosh <joe.swatosh@gmail.com> wrote:
> > >On 12/29/06, Vlad Georgescu <vgeorgescu@gmail.com> wrote:
> > >> On 12/29/06, Joe Swatosh <joe.swatosh@gmail.com> wrote:
> > >
> > >>

>
> The indentation level appears to be off here for both the "if"
> statement and its enclosed code block.
>
> >
> > fakeincludes.append(self.apath(self.zlib_path))
> >
> > @@ -738,6 +743,8 @@
> > or isinstance(target, gen_base.TargetSWIGLib)):
> > if target.lang == "python" and self.python_libdir:
> > fakelibdirs.append(self.python_libdir)
> > + if target.lang == "ruby" and self.ruby_libdir:
> > + fakelibdirs.append(self.ruby_libdir)
>
> Ditto. Joe, do you need to tweak some GMail setting to make it more
> friendly with leading whitespace? I've noticed this issue with some
> of your other patches as well.
>

Thanks for the heads-up. I don't see any GMail setting that would
make a difference. Locally the indentation looks okay (as far as I
understand Python indentation -- not much). So its probably operator
error. Perhaps I should attach them instead of pasting?

Apparently I am intermittently sending these patches to the Tortoise
Users and the RapidSVN Dev lists as well. I have no idea how _that_
is happening. The headers look right on the sent version, but sure
enough I see the messages in gmane. I'd love to hear any hints on
that also.

> > @@ -953,6 +965,30 @@
> > finally:
> > fp.close()
> >
> > + def _find_ruby(self):
> > + "Find the right Ruby library name to link swig bindings with"
> > + self.ruby_includes = []
> > + self.ruby_libdir = ""
>
> We can initialize ruby_libdir to None instead of "".
>

I just copied what was in the Python version. None makes more sense
to me too, FWIW.

It'd be neat if someone could figure out how to do this for Perl too.

>
> Looks good.
>

Thanks. I hope someone will validate (or fix) and commit it.

--
Joe Swatosh
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org