RE: [PATCH] Display stderr before throwing exception in the python test suite

Madan,
Why to map sys.stdout.write of invoker to stderr_lines of child?
If the purpose is to help in identifying the root cause, why not make use of stdout_lines also?
Or may be,
+ map(sys.stdout.write, stdout_lines)
+ map(sys.stderr.write, stderr_lines)

Somehow I am seeing less use for this patch, I may be wrong!.

IIRC SVNProcessTerminatedBySignal is raised for segfaults and aborts. In both the cases you may not have anything useful in the stderr stream. I have verified the current trunk and could confirm that we never write anything to stderr prior to abort.

May be useful for 'abort invoked through asserts'. Did you encounter such aborts?

With regards
Kamesh Jayachandran

-----Original Message-----
From: Madan U S [mailto:madan@collab.net]
Sent: Sun 12/31/2006 9:35 AM
To: dev@subversion.tigris.org
Subject: [PATCH] Display stderr before throwing exception in the python test suite
 

Hi,

   I was stuck with a failure of checkout_tests in the incomplete-directories branch, because the test was throwing an exception 'EXCEPTION: SVNProcessTerminatedBySignal', but I had no clue what was failing.

   This was thrown from run_command_stdin(), if the exit code was not 0. It would have been very convinient to solve the root-cause of failure, if only I could the stderr - if any, at this point.

   Please find attached a patch that does this (the patch is for trunk - I can later forward port it to incomplete-directories).

Regards,
Madan.
Received on Sun Dec 31 13:10:44 2006