[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Issue 1627: Create subversion DLLs on Windows

From: Branko ─îibej <brane_at_xbc.nu>
Date: 2006-12-30 22:49:59 CET

Vlad Georgescu wrote:
> On 12/18/06, Vlad Georgescu <vgeorgescu@gmail.com> wrote:
>> I attached the updated log message and patch.
>
> Two more problems I discovered:
>
> 1. I forgot to add svn_nls.h to the list of header files for
> libsvn_subr. (I don't build with ENABLE_NLS, so I didn't realize this
> until I tried to build the python bindings, which wrap svn_nls_init).
>
> 2. The swig_{client,delta,fs,ra,repos} targets should explicitly
> depend on APR because they use apr_palloc in some places. This worked
> previously because if a project depends on a static library, the
> library's dependencies are recursively added to the dependent project.
> This doesn't happen with shared libs, causing linker errors.
>
> I updated the log message and patch to address these issues.

I finally got the chance to test this. Had to tweak it a bit so that it
works with MSVC 6, but (local) tests are looking great now.

I have one question about exporting svn_ctype_table. My linker complains
that the CONSTANT keyword in the .def file is deprecated, and that DATA
should be used instead. I don't recall the reason for using CONSTANT
instead of DATA; I thought that the end result was the same?

I suspect I'll commit this as soon as the tests pass.

-- Brane

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Dec 30 22:50:25 2006

This is an archived mail posted to the Subversion Dev mailing list.