Ben Collins-Sussman wrote:
> Sorry, I don't approve of this patch, I think it's misleading.
>
> The only thing it's doing is noticing when a GET request comes in that
> has no X-SVN-Base: header. That could be any number of things. It
> could be someone running 'svn cat'. It could be an ordinary web
> browser surfing the repository.. It could be someone running 'curl'.
> It could even be libsvn_ra_serf doing a checkout!
>
> I do not think all four of those scenarios should be listed as "svn
> cat" in a high-level log. Furthermore, I don't think a lone GET
> request is "high level" in the first place. It's low-level, and thus
> the apache access.log is already logging it.
>
The idea behind this patch is to log all svn operations to one file, so
that one can analyse single file for svn usage analysis, rather than
analysing both access.log and svbversion.log.
Just before sending the patch, I thought about the web request, and
decided to log as 'cat-or-web-browse'(I did not realize serf checkouts
to be series of GETS!).
Somehow my testing revealed that this patch did not log web request but
only 'svn cat'. So I decided to log 'cat /path rR', as it only logged
'svn cat'.
Today after getting your email I just reverified and found that 'web
requests'/serf checkouts is getting logged as 'cat ...'(Not sure why I
got a misleading results yesterday!).
Thanks for pointing to peculiarity of 'serf'. How curl is different? is
it not same as web browser?
With regards
Kamesh Jayachandran
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Dec 21 10:38:08 2006