[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r22765 - trunk/subversion/libsvn_client

From: Daniel Rall <dlr_at_collab.net>
Date: 2006-12-20 16:29:41 CET

On Wed, 20 Dec 2006, Kamesh Jayachandran wrote:
...
> >>Given the call it can only modify '&pair->src_kind' as 'pair->src_kind'
> >>is an enum it does not need any allocation, so no need to worry abt pool
> >>destruction.
> >
> >I think Kamesh is right on this one. The use of the pool parameter
> >isn't documented in svn_io.h, and looking at the internals, pool is only
> >used for allocations inside svn_io_check_path, not for anything that
> >gets returned. pair->src_kind isn't allocated, just set to an enum value.

I've tweaked the documentation of svn_io_check_path() in r22771 to
note that POOL is only used for temporary allocations (I'm assuming
errors fall into this category).

> Yes we do so the same 9 lines downwards
>
> SVN_ERR(svn_io_check_path(pair->dst, &dst_kind, iterpool));

I specifically didn't use POOL here, since we were changing the value
of a local variable.

  • application/pgp-signature attachment: stored
Received on Wed Dec 20 16:31:37 2006

This is an archived mail posted to the Subversion Dev mailing list.