[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: JavaHL setConfigDirectory() and auth cache problems

From: Mark Phippard <markphip_at_gmail.com>
Date: 2006-12-20 02:00:22 CET

On 12/19/06, Daniel Rall <dlr@collab.net> wrote:

> > 2) If the Subversion config area does not exist, then it is created
> > automatically when the JavaHL library is loaded. However, if the
> > folder does exist, or has incomplete contents, then no attempt is
> > made to fill the folder with the correct contents. The way this
> > manifests is that when the user is prompted to accept SSL
> > credentials, the Accept Permanent does not work because the
> > auth/svn.ssl.server folder does not exist. I did not test if
> > password cache has same problem, but I'd expect that it would.
> >
> > I tested scenario #2 with the command line, and it created the
> > necessary folders to store the cache info. JavaHL does not.
>
> Mark, is this caused by the bug injected by r21316? Or is this a
> different problem?

Hopefully it is the same problem. I have no way of knowing.

Wouldn't it be possible to have the code treat "" the same as NULL? I think
when we committed it, we thought that it did. Probably because line 2872 in
SVNClient.cpp:

        m_configDir = (configDir == NULL ? "" : configDir);

I now see that the issue is that this code is AFTER the svn library call has
been made. I guess we can live with this if the change is reverted, but I
am not sure a JVM crash is the lesser of two evils.

-- 
Thanks
Mark Phippard
http://markphip.blogspot.com/
Received on Wed Dec 20 02:00:37 2006

This is an archived mail posted to the Subversion Dev mailing list.