On 12/19/06, David James <james@cs.toronto.edu> wrote:
> On 12/18/06, Kamesh Jayachandran <kamesh@collab.net> wrote:
> > Sorry for stepping outside my area.
> >
> > If it was a feature or bug fix definitely would have waited for someone
> > to respond and would have expressed my [+/-]1 to those patches.
> >
> > As it was a compile failure and the patch was obvious enough, I felt
> > like committing.
>
> Kamesh, it's great to see that you are so dedicated to improving
> Subversion. Still, it's a good idea to follow the rules to the letter
> so that we can be sure all of your patches are appropriately reviewed.
> The "obvious fix" rule (which allows you to commit changes outside
> your area without review) only applies to documentation or code
> comments -- not actual code.
>
> Next time, post your patch to the dev@ list, and if it fixes an
> important compile error, I am sure it will be reviewed and committed
> quickly by a full committer.
>
> Thanks for your work!
P.S. (I've edited the log message for r22732 to indicate that your
commit is now approved by me.)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Dec 19 19:33:23 2006