[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r22715 - in trunk/subversion: include libsvn_client

From: Daniel Rall <dlr_at_collab.net>
Date: 2006-12-15 20:23:19 CET

On Thu, 14 Dec 2006, Hyrum K. Wright wrote:

> Just one compile-time warning:
>
> dlr@tigris.org wrote:
> > Author: dlr
> > Date: Thu Dec 14 15:28:51 2006
> > New Revision: 22715
> >
> > Log:
> > Make use of the rev'd commit item structure made available in r22674
> > to provide a facility for sending extra property changes from client
> > to repository.
> ...
> > Modified: trunk/subversion/libsvn_client/ra.c
> > URL: http://svn.collab.net/viewvc/svn/trunk/subversion/libsvn_client/ra.c?pathrev=22715&r1=22714&r2=22715
> > ==============================================================================
> > --- trunk/subversion/libsvn_client/ra.c (original)
> > +++ trunk/subversion/libsvn_client/ra.c Thu Dec 14 15:28:51 2006
> > @@ -139,7 +139,7 @@
> >
> > if (strcmp(relpath, svn_path_uri_decode(item->url, pool)) == 0)
> > {
> > - apr_pool_t *cpool = item->wcprop_changes->pool;
> > + apr_pool_t *cpool = item->incoming_prop_changes->pool;
> > svn_prop_t *prop = apr_palloc(cpool, sizeof(*prop));
> >
> > prop->name = apr_pstrdup(cpool, name);
> > @@ -153,7 +153,7 @@
> >
> > /* Buffer the propchange to take effect during the
> > post-commit process. */
> > - *((svn_prop_t **) apr_array_push(item->wcprop_changes)) = prop;
> > + APR_ARRAY_PUSH(item->incoming_prop_changes, svn_prop_t **)= prop;
> ^
> Shouldn't this be 'svn_prop_t *'?

Yup, thanks Hyrum. Fixed in r22718.

- Dan

  • application/pgp-signature attachment: stored
Received on Tue Dec 19 02:02:22 2006

This is an archived mail posted to the Subversion Dev mailing list.