[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Bug in SVN::Client

From: John Peacock <jpeacock_at_rowman.com>
Date: 2006-12-14 15:12:50 CET

C. Michael Pilato wrote:
> I'm not exactly sure why you've decided that the environment variable
> approach is fundamentally broken.

It's not that it is fundamentally broken; it is just remarkably fragile
in the face of the common behavior of running server tasks in a
restricted environment. If you make the assumption that the exposure of
this behavior is limited to "user-initiated execution" then it is
reasonable to rely on the convention that $HOME (or the Win32
equivalent) contains a valid path. It was a rude surprise, however,
that executing the client libraries under mod_perl (which is most
certainly *not* a normal user environment) would behave so badly for
little or no reason.

> That said, I'm certainly not convinced that erroring out is required,
> especially given my recollection that the code doesn't care if the
> .subversion directory is present and readable yet empty.

Since I don't have anything more important to contribute to the project
at the moment, I'll try to take on this [hopefully bite-sized] task and
produce a patch to reduce the error to a warning. It won't be until
after winter break however (unless I get some time to myself on vacation).

John

-- 
John Peacock
Director of Information Research and Technology
Rowman & Littlefield Publishing Group
4501 Forbes Boulevard
Suite H
Lanham, MD  20706
301-459-3366 x.5010
fax 301-429-5748
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Dec 14 15:14:39 2006

This is an archived mail posted to the Subversion Dev mailing list.