[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Bug in SVN::Client

From: John Peacock <jpeacock_at_rowman.com>
Date: 2006-12-14 01:08:06 CET

John Peacock wrote:
> No that doesn't fix it; it really is due to the real UID being 0 and the
> effective UID not having access to root's files. I've traced back as
> far as svn_config_get_config() but I haven't worked my way back to
> discover the algorithm that tries to find the HOME on it's own.

This seems to be a very fragile design decision:

$ HOME=/dev/null svn --version
svn: Can't open config file '/dev/null/.subversion/servers'

It makes no sense to me to depend on an environment variable (which anyone can
monkey with), then die if that contains nonsense (or inaccessible files), when
the configuration in question can legitimately be initialized as NULL with no
harm. At the very minimum this should throw a warning; to have it error out is
just overkill.

John

-- 
John Peacock
Director of Information Research and Technology
Rowman & Littlefield Publishing Group
4501 Forbes Blvd
Suite H
Lanham, MD 20706
301-459-3366 x.5010
fax 301-429-5747
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Dec 14 01:08:25 2006

This is an archived mail posted to the Subversion Dev mailing list.