[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r22678 - trunk/subversion/libsvn_client

From: David Glasser <glasser_at_mit.edu>
Date: 2006-12-13 02:40:47 CET

On 12/12/06, dlr@tigris.org <dlr@tigris.org> wrote:

>
> +/* CTX is of type "svn_client_ctx_t *". */
> +#define SVN_CLIENT__HAS_LOG_MSG_FUNC(ctx) \
> + (ctx->log_msg_func3 || ctx->log_msg_func2 || ctx->log_msg_func)
> +

Shouldn't the ctx's in the expansion be parenthesized to avoid
precedence mixups if the argument is weird?

--dave 

-- 
David Glasser | glasser_at_mit.edu | http://www.davidglasser.net/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Dec 13 02:41:00 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.