[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r22653 - branches/ra_dav-refactoring/subversion/libsvn_ra_dav

From: Daniel Rall <dlr_at_collab.net>
Date: 2006-12-12 02:38:23 CET

On Mon, 11 Dec 2006, Daniel Rall wrote:

> On Mon, 11 Dec 2006, dionisos@tigris.org wrote:
> ...
> > --- branches/ra_dav-refactoring/subversion/libsvn_ra_dav/util.c (original)
> > +++ branches/ra_dav-refactoring/subversion/libsvn_ra_dav/util.c Mon Dec 11 15:43:58 2006
...
> > +static svn_error_t *
> > +spool_reader(void *userdata,
> > + const char *buf,
> > size_t len)
> > {
> > spool_reader_baton_t *baton = userdata;
> >
> > - if (! baton->req->err)
> > - baton->req->err = svn_io_file_write_full(baton->spool_file, buf,
> > - len, NULL, baton->req->iterpool);
> > + SVN_ERR(svn_io_file_write_full(baton->spool_file, buf,
> > + len, NULL, baton->req->iterpool));
> > svn_pool_clear(baton->req->iterpool);
> >
> > - if (baton->req->err)
> > - /* ### Call ne_set_error(), as ne_block_reader doc implies? */
> > - return 1;
> > - else
> > - return 0;
> > + return SVN_NO_ERROR;
> > }
>
> The previous 3 lines could be reduced to:
>
> return svn_io_file_write_full(...);

Never mind, that's not correct. My eyes passed right over the clear
of the iteration pool without seeing it.

  • application/pgp-signature attachment: stored
Received on Tue Dec 12 02:39:53 2006

This is an archived mail posted to the Subversion Dev mailing list.