[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: ra_dav refactoring: approaching branch merge-back point

From: Daniel Rall <dlr_at_collab.net>
Date: 2006-12-11 20:47:49 CET

On Mon, 11 Dec 2006, Erik Huelsmann wrote:

> After my series of commits from last weekend, the ra_dav-refactoring
> branch is approaching 'completion': Almost all changes I intended have
> been incorporated (except for the point addressed in my mail from last
> night).
>
> These points have been addressed:
>
> - Reduced Neon type useage (which need manual tracking and destruction)
> - Eliminated all marshalling of errors through the Neon layer in xml
> callbacks
> (making sure we leak no more).
> - Reduced integration between internal ra_dav APIs and Neon's public API
> - Eliminated necessity for Neon request callbacks to attach custom error
> parser to Neon requests.
> - Moved from manual allocation of requests into the 2 neon sessions to
> automatic session selection.
> - Separated locking code into a dedicated file.
> - Code simplifications by reducing the number of manually destructed
> resources.
>
>
> Code review of the branch diff is most welcome!
>
> Without any comments, I'll merge the branch to trunk one week after
> the last commit (I may commit some minor cleanups in the days to come)
> meaning it won't happen before next week.

Very cool!

I'm in favor of merging, but am somewhat concerned about regressions.
Do any of the changes warrant additional DAV-specific tests, or is the
existing regression test suite sufficient?

  • application/pgp-signature attachment: stored
Received on Mon Dec 11 20:41:41 2006

This is an archived mail posted to the Subversion Dev mailing list.