[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: ra_dav refactoring: approaching branch merge-back point

From: Garrett Rooney <rooneg_at_electricjellyfish.net>
Date: 2006-12-11 16:44:57 CET

On 12/11/06, Erik Huelsmann <ehuels@gmail.com> wrote:
> After my series of commits from last weekend, the ra_dav-refactoring
> branch is approaching 'completion': Almost all changes I intended have
> been incorporated (except for the point addressed in my mail from last
> night).
>
> These points have been addressed:
>
> - Reduced Neon type useage (which need manual tracking and destruction)
> - Eliminated all marshalling of errors through the Neon layer in xml callbacks
> (making sure we leak no more).
> - Reduced integration between internal ra_dav APIs and Neon's public API
> - Eliminated necessity for Neon request callbacks to attach custom error
> parser to Neon requests.
> - Moved from manual allocation of requests into the 2 neon sessions to
> automatic session selection.
> - Separated locking code into a dedicated file.
> - Code simplifications by reducing the number of manually destructed resources.
>
>
> Code review of the branch diff is most welcome!
>
> Without any comments, I'll merge the branch to trunk one week after
> the last commit (I may commit some minor cleanups in the days to come)
> meaning it won't happen before next week.

I haven't had time to take an in depth look at this stuff, although
the bits I have seen are quite nice. I will say that I'm VERY glad to
see Erik taking a look at this stuff, I've been of the opinion for a
while now (mostly since seeing what Justin did with ra_serf) that
ra_dav could be much nicer code if it had some attention, as opposed
to just letting it evolve over time and retain its various backwards
compatibility shims and hacks like we had done up to now, and Erik's
recent work seems to be proving that to truly be the case.

-garrett

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Dec 11 16:45:20 2006

This is an archived mail posted to the Subversion Dev mailing list.