[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] match_glob_list ! enhancement

From: Kyle McKay <mackyle_at_tigris.org>
Date: 2006-11-30 23:20:35 CET

On Nov 30, 2006, at 12:55, David Glasser wrote:
> On 11/26/06, Kyle McKay <mackyle@tigris.org> wrote:
>> [[[
>> Add support for negation (!) in pattern glob lists
>>
>> * subversion/libsvn_subr/svn_string.c
>> (svn_cstring_match_glob_list): Add support for negation patterns
>> ]]]
>
> One thing that's worth pointing out is that
> svn_cstring_match_glob_list is used in a couple of random places other
> than ignores. Would it make more sense to restrict this feature to
> svn_wc_match_ignore_list?

Introducing a new svn_wc_match_ignore_list function would obviously
cause several more files to be touched by the changes although the
additional changes should primarily consist of substituting a call to
svn_cstring_match_glob_list with the new svn_wc_match_ignore_list.

There appear to be two places svn_cstring_match_glob_list is used
that are not directly related to processing ignore lists:

1. The http-proxy-exceptions option in the config [global] section.
2. The [groups] section in the config.

(If I missed something else, please let me know.)

I'm certainly not opposed to moving the change to a client specific
area, but both import and add need to use it so it's not necessarily
working copy specific. Perhaps an svn_cstring_match_except_glob_list
function instead?

But I think the ability to use the "!" negation option in both the
http-proxy-exceptions and [groups] configurations would also be
beneficial. You could then easily define a group consisting of all
hosts from a domain except for a few or list as http proxy exceptions
all hosts except one or two.

Since "!" is not a valid character in a host name (either domain name
or IP literal or IPv6 literal), the http-proxy-exceptions and
[groups] settings gain a 100% backwards compatible enhancement.

Part of the patch should probably include adding some comments to the
svn_string.h header for the svn_cstring_match_glob function
declaration to mention the exception behavior with globs that start
with '!'.

Kyle

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Nov 30 23:21:13 2006

This is an archived mail posted to the Subversion Dev mailing list.