[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r22476 - in branches/1.4.x: . subversion/tests/cmdline

From: Daniel Rall <dlr_at_collab.net>
Date: 2006-11-28 18:27:33 CET

On Tue, 28 Nov 2006, Peter Samuelson wrote:

>
> [dlr@tigris.org]
> > --- branches/1.4.x/subversion/tests/cmdline/davautocheck.sh (original)
> > +++ branches/1.4.x/subversion/tests/cmdline/davautocheck.sh Tue Nov 28 08:59:29 2006
> > @@ -99,6 +99,15 @@
> > # dont assume sbin is in the PATH
> > PATH="/usr/sbin:/usr/local/sbin:$PATH"
> >
> > +# Remove any proxy environmental variables that effect wget or curl.
> > +# We don't need a proxy to connect to localhost and having the proxy
> > +# environmental variables set breaks the Apache configuration file
> > +# test below, since wget or curl will ask the proxy to connect to
> > +# localhost.
> > +export -n PROXY
> > +export -n http_proxy
> > +export -n HTTPS_PROXY
>
> Hmmm. I didn't notice this when it hit trunk.
>
> I know you don't care all that much whether "#!/bin/sh" actually means
> "#!/bin/sh", but this introduces a bashism that could easily be
> avoided:
>
> unset PROXY
> unset http_proxy
> unset HTTPS_PROXY
>
> This was tested on five non-bash shells (ksh88, ksh93, zsh, dash,
> posh), none of which recognize "export -n".

I'd prefer "#!/bin/sh" to mean Bourne shell. We should use the more
portable "unset", or change this script to "#!/bin/bash". Blair, you
see anything wrong with the using 'unset' instead of 'export -n'?

- Dan

  • application/pgp-signature attachment: stored
Received on Tue Nov 28 18:29:01 2006

This is an archived mail posted to the Subversion Dev mailing list.