[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Avoid importing unused libraries in tests scripts

From: Daniel Rall <dlr_at_collab.net>
Date: 2006-11-28 17:35:34 CET

On Tue, 28 Nov 2006, Bhuvaneswaran Arumugam wrote:

> Hello,
>
> This is a follow-up for r22444. This time it fixes the issues in scripts
> under tests/cmdline/svntest directory. Please find attached the patch
> for review.
>
> [[
> Avoid importing unused python libraries in the black box regression
> tests.
>
> [ in subversion/tests/cmdline/svntest ]
> * testcase.py
> Do not import unused libraries.
> (TestCase.check_description): Use the string itself when invoking the
> lower() function.
>
> * tree.py
> Do not import unused libraries.
> (create_from_path, dump_tree): Use the string itself when invoking the
> replace() function.
> (get_props): Use the string itself when invoking the strip() function.
>
> * actions.py
> Do not import unused libraries.
> (setup_pristine_repository, run_and_verify_commit): Use the string
> itself when invoking strip() function.
>
> * main.py
> Do not import unused libraries.
> Use the string itself when invoking replace() function.
> (Sandbox._set_name, run_tests): Use the string itself when invoking
> replace() function.
>
> Patch by: bhuvan
> ]]

Looks good, Bhuvan. Please commit to trunk.

- Dan

  • application/pgp-signature attachment: stored
Received on Tue Nov 28 17:37:01 2006

This is an archived mail posted to the Subversion Dev mailing list.