[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Neon 0.26.2

From: Stefan Küng <tortoisesvn_at_gmail.com>
Date: 2006-11-24 16:22:14 CET

D.J. Heap wrote:
> On 11/20/06, Stefan Küng <tortoisesvn@gmail.com> wrote:
>> Samay wrote:
>>
>> > I tested the binaries with abpve patch and it doesnt work. Specific to
>> > link provided above (fix by Stefan) seems like a different problem but
>> > with similar error. Difference from this bug summary is
>> > a) its SSPI on & Basic On (or Basic Off), Mod_auth_kerb 5.0_RC6, RHEL4,
>> > Active Directory 2k3. (works fine with Firefox and IE)
>> > b) user computer is in the AD domain.
>>
>> The patch only fixes one problem. I haven't added the additional check
>> in all places. You can find two or three more places in the same file
>> (where the patch applies to) which call svn_auth_first_credentials().
>> Can you try to patch all those places and try again please?
>> (don't search for "(attempt == 0)" but for svn_auth_first_credentials()
>> - in the other places it's "(try == 0)" which has to be patched)
>>
>
>
> I looked at this again today and I don't see where the other uses of
> svn_auth_next_credentials could ever be called without
> svn_auth_first_credentials being called. Am I missing something in
> those other spots?

I can't see either that this would segfault. But since neon obviously
doesn't guarantee that the 'attempt' param is zero the first time a
callback is called, I think it would be wise to add the additional
checks there too.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Nov 24 16:22:37 2006

This is an archived mail posted to the Subversion Dev mailing list.