Re: svn commit: r22414 - in branches/multiple-moves/subversion: include libsvn_client

On 11/23/06, hwright@tigris.org <hwright@tigris.org> wrote:
> Log:
> Stub out the svn_client_*_into APIs, but don't change the underlying
> functionality, just truncate src_paths argument when performing the copy
> or move.

For what it's worth, it's probably worth mentioning that it's a stub
in a comment in addition to the log message (even though this is a
private branch).

> /**
> + * Copy all @a src_paths into @a dst_dir.
> + *
> + * Use the same semantics as svn_client_copy3(), but with the following
> + * changes:

I'm not sure that it does use the same semantics, since copy3 doesn't
automatically put things into directories (unlike copy2). Though
maybe that's not what you're getting at.

> +/**
> + * Move all @a src_paths into @a dst_dir.
> + *
> + * Each one of @a src_paths must be a file or directory under version
> + * control, or the URL of a versioned item in the repository. They
> + * must also all be of the same type, e.g., all URLs or all WC paths.
> + *
> + * @a dst_path must be a directory.

You mean dst_dir.

> + return setup_copy(commit_info_p, src_path, src_revision, dst_path,
> + FALSE /* is_move */,
> + TRUE /* force, set to avoid deletion check */,

I don't get why you need that force, but I'll leave this nit until the
actual implementation is written :-)

The main question I think when I see these new APIs, which is only
partially addressed by your documentation, is what amount of atomicity
will occur. I suppose that for ->repo operations it'll clearly be
atomic since it's a commit; how about for ->wc operations? Will
failure result in some copies having occured and others not occuring?
If there's an error, will the ones afterwards still be attempted?

(I'm not sure what the right answers to these questions are, both in
terms of useful API design and implementability.)

--dave

-- 
David Glasser | glasser_at_mit.edu | http://www.davidglasser.net/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org