Re: [PATCH][merge-tracking]Data loss due to line buffered SAX stream on mergeinfo retrieval.
From: Daniel Rall <dlr_at_collab.net>
Date: 2006-11-20 19:54:59 CET
On Mon, 20 Nov 2006, Kamesh Jayachandran wrote:
Nice find, Kamesh! I (and DannyB, apparently) didn't realize that our
o A single merge source (one line)
I've committed a similar fix in r22369, which also addresses my
> --- subversion/libsvn_ra_dav/mergeinfo.c (revision 22315)
This will index off the end of the "mutable_cdata" string, which is
Looks like an attempt to avoid copying "cdata"...
> + mutable_cdata[len]='\0';
We did it again, only this time we clobbered something else's memory.
Spacing is also missing from around the "=" character.
> + mb->curr_info = apr_pstrcat(mb->pool, mb->curr_info, cdata, NULL);
What happens when mb->curr_info hasn't been set yet?
> + mutable_cdata[nlen] = tmpc;
Now we attempt to restore the data we previously clobbered, again
This is an archived mail posted to the Subversion Dev mailing list.