[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r22346 - in trunk/subversion: libsvn_ra_dav libsvn_ra_serf mod_dav_svn/reports

From: David Glasser <glasser_at_mit.edu>
Date: 2006-11-20 15:08:29 CET

On 11/19/06, glasser@tigris.org <glasser@tigris.org> wrote:
> In the DAV implementations of svn_ra_replay, make sure to pass the
> checksum argument to close_file through instead of ignoring. (Note
> that this is basically untested, because the svn_repos_replay2 editor
> driver doesn't actually calculate checksums; I would like to fix that,
> and this is consistent with ra_svn and ra_local at least.)

So I don't have a good apache setup for testiing. Can somebody do me
a favor and apply the following patch and run svnsync_tests under
ra_dav and/or ra_serf, and confirm that they fail with a checksum
error? (That is, confirm that the checksum argument to close_file
actually does make it through to the client now?) And that it passes
without these checks?

Thanks!
dave

=== subversion/libsvn_repos/replay.c
==================================================================
--- subversion/libsvn_repos/replay.c (revision 108736)
+++ subversion/libsvn_repos/replay.c (local)
@@ -615,7 +615,8 @@
       unsigned char digest[APR_MD5_DIGESTSIZE];
       SVN_ERR(svn_fs_file_md5_checksum(digest, root, path, pool));
       SVN_ERR(editor->close_file(file_baton,
- svn_md5_digest_to_cstring(digest, pool),
+/* svn_md5_digest_to_cstring(digest, pool), */
+ "bla bla",
                                  pool));
     }

-- 
David Glasser | glasser_at_mit.edu | http://www.davidglasser.net/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Nov 20 15:09:27 2006

This is an archived mail posted to the Subversion Dev mailing list.